Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inference] conv2d_fuison op support codegen #58650

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

yuanlehome
Copy link
Contributor

@yuanlehome yuanlehome commented Nov 3, 2023

PR types

Others

PR changes

Others

Description

  • conv2d_fuison op support codegen
  • 把conv2d_fuison这个op的cutlass后缀给删了,统一使用conv2d_fuison这个名字,通过use_cudnn这个属性来决定调用cudnn的实现还是cutlass的实现

Others

Pcard-71500

Copy link

paddle-bot bot commented Nov 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link

paddle-ci-bot bot commented Nov 14, 2023

Sorry to inform you that 39fa7c4's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

zyfncg
zyfncg previously approved these changes Nov 27, 2023
@yuanlehome yuanlehome changed the title [Inference] move conv2d_fuison op to phi [Inference] conv2d_fuison op support codegen Nov 27, 2023
sunzhongkai588
sunzhongkai588 previously approved these changes Nov 27, 2023
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no docs changes

@yuanlehome yuanlehome dismissed stale reviews from sunzhongkai588 and zyfncg via f4b2481 November 27, 2023 05:12
Copy link
Contributor

@zhoutianzi666 zhoutianzi666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -85,6 +85,7 @@
'fusion_gru',
'fusion_seqconv_eltadd_relu',
'fusion_seqexpand_concat_fc',
'conv2d_fusion',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个api命名方式跟其他fusion类api不一样,是什么原因呢?

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后续改下conv_fusion的名称跟其他fused算子一致

@yuanlehome
Copy link
Contributor Author

后续改下conv_fusion的名称跟其他fused算子一致

好的,根据沟通结果,下一个PR将paddle内部的conv2d_fusion及其相关pass/op type/文件名等统一改为fused_conv2d_add_act

@yuanlehome yuanlehome merged commit 31961c6 into PaddlePaddle:develop Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants